How's My Voice???

Learning more about singing. If there is any thing which I should learn and practice more comment regarding that so that It helps me to be a good singer. Thank You